feat(tor): persist transport preferences - #2584
Merged
Merged
Conversation
|
Claude finished @ethicnology's task in 11m 54s —— View job PR Review in progress
|
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 10, 2026 20:10
7a1713e to
6c0e23c
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
2 times, most recently
from
August 10, 2026 21:46
5598993 to
b56653d
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 11, 2026 00:52
b56653d to
36ef1d0
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
3 times, most recently
from
August 17, 2026 17:08
fb4089d to
82af08c
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 17, 2026 18:28
82af08c to
8bc64eb
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 18, 2026 15:05
8bc64eb to
66aeed3
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 18, 2026 15:07
66aeed3 to
d50ae7e
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 18, 2026 15:36
d50ae7e to
1f5dfb4
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 18, 2026 15:37
1f5dfb4 to
2e01cfb
Compare
ethicnology
force-pushed
the
feat/tor-persistence
branch
from
August 18, 2026 18:40
2e01cfb to
6c5dd70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the
feat/tor-settingsPR. Review that one first.The chosen transport mode — automatic, direct, or Snowflake — now survives a restart. Until this PR the choice was rebuilt from defaults on every launch, so a user in a censored network had to re-select Snowflake each time they opened the app, which is precisely when they can least afford the extra round of failed bootstraps.
Storage side: Drift schema v14 → v15 adds the column, with the migration step, the generated schema snapshot, and a
schema_v14_to_v15_testthat exercises the upgrade.UpdateTorTransportModeUsecaseowns the write, and the settings entity, model, datasource and repository carry the field.UI side: the transport selector in
tor_proxy_widgetreads and writes the persisted value, with its l10n keys added to the English template.The bulk of the diff is generated code —
drift_schema_v15.json,sqlite_database.steps.dartand the generated schema test fixtures account for roughly 11k of the 11.4k inserted lines. The hand-written part is small and worth reading on its own.